Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 Translate component #6691

Open
Zasa-san opened this issue Apr 22, 2024 · 1 comment · May be fixed by #6569
Open

V2 Translate component #6691

Zasa-san opened this issue Apr 22, 2024 · 1 comment · May be fixed by #6569

Comments

@Zasa-san
Copy link
Collaborator

Front end team has been working on a V2 Translate component. The aim is to remove redux dependencies from translations, so that new routes have as few dependencies from V1 as possible.

To cover in the PR we have been working on:

  • Migrate the Translate component to use atoms and not redux
  • Migrate the t function in the same way
  • If possible, use V2 translations API data structure
  • If possible, stop depending on redux for the initial state of the app
@Zasa-san Zasa-san linked a pull request Apr 22, 2024 that will close this issue
9 tasks
This was referenced May 14, 2024
@Zasa-san
Copy link
Collaborator Author

Zasa-san commented Oct 2, 2024

We should check if the languages listed in /settings/languages are meant to be translatable. By default, they are not listed in the translationsV2 collection. They are currently translatable, and I understand that our system allows you to translate keys that are not present in the translationsV2 collection. I recall those not being translatable.

In any case, we need to remember that if a term is not present in the context users should still be able to translate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants