Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 translate #6569

Draft
wants to merge 94 commits into
base: development
Choose a base branch
from
Draft

V2 translate #6569

wants to merge 94 commits into from

Conversation

Zasa-san
Copy link
Collaborator

@Zasa-san Zasa-san commented Mar 6, 2024

fixes #6691

  • Update translation sockets actions to update atom store and not redux
  • Tests (test that atoms update via sockets, test that when you submit translations the socket even is fired?, we are not updating the translationsAtom after submitting, so consistency across the UI depends on sockets)
  • Refactor (for example t has circular deps)
  • API changes need to be reviewed
  • Modal styles
  • Cleanup
  • After merging, create issue to migrate form so that we can remove the old translations endpoitns
  • Modal stacking. Translate modal can be triggered by other modals. It should always sit on top of all other app elements.
  • Changes to the dropdown menu for language selection might impact pages?

@Zasa-san
Copy link
Collaborator Author

We should also check this -> #5068

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V2 Translate component
4 participants