Implement stalled connection detection and handling in BrokerConnection - #55
Merged
Merged
Conversation
- Introduced `stalled_connection_error` to handle errors when a connection is stalled due to unanswered requests. - Added logic to detect stalled connections in `BrokerConnection`, closing the connection if a request remains unanswered beyond a grace period. - Enhanced tests to verify the behavior of the connection when requests are stalled, ensuring that the connection closes and retries occur as expected. - Updated `ShareConsumer` to notify when assignments are installed and to wait for assignments during polling. - Implemented a retry mechanism for joining the coordinator in `ShareConsumer`, handling common coordinator errors gracefully. - Added functionality to close share sessions with a final-epoch `ShareAcknowledge`, ensuring proper cleanup of sessions. - Updated tests to validate the behavior of share consumers and producers in scenarios involving connection stalls and session closures.
…n consumer module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
stalled_connection_errorto handle errors when a connection is stalled due to unanswered requests.BrokerConnection, closing the connection if a request remains unanswered beyond a grace period.ShareConsumerto notify when assignments are installed and to wait for assignments during polling.ShareConsumer, handling common coordinator errors gracefully.ShareAcknowledge, ensuring proper cleanup of sessions.fixes #54