fix: compatibility with exactOptionalPropertyTypes #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With [`exactOptionalPropertyTypes`](https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes) enabled, optional properties cannot be `undefined` unless explicitly allowed. This commit explicitly allows optional properties to be `undefined`, making Vaul Svelte usable in projects with `exactOptionalPropertyTypes` enabled.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With
exactOptionalPropertyTypesenabled, optional properties cannot beundefinedunless explicitly allowed. This commit explicitly allows optional properties to beundefined, making Vaul Svelte usable in projects withexactOptionalPropertyTypesenabled.The issue was discovered when fixing compatibility with
exactOptionalPropertyTypesin shadcn-svelte in huntabyte/bits-ui#516, melt-ui/melt-ui#1256, and svecosystem/paneforge#34. This PR makes the Drawer component usable in projects withexactOptionalPropertyTypesenabled.