Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expose portal prop on the date pickers #652

Merged
merged 2 commits into from
Sep 12, 2024
Merged

fix: expose portal prop on the date pickers #652

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8aac11b
fix: expose `portal` prop on the date pickers
NDOY3M4N Sep 4, 2024
d13a9bb
add changeset
huntabyte Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/healthy-mangos-hang.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"bits-ui": patch
---

fix(Date Pickers): expose `portal` prop
2 changes: 2 additions & 0 deletions packages/bits-ui/src/lib/bits/date-picker/components/date-picker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

type $$Props = Props;

export let portal: $$Props["portal"] = undefined;
export let open: $$Props["open"] = undefined;
export let onOpenChange: $$Props["onOpenChange"] = undefined;
export let value: $$Props["value"] = undefined;
Expand Down Expand Up @@ -167,6 +168,7 @@
$: updateOption("weekdayFormat", weekdayFormat);
$: updateOption("numberOfMonths", numberOfMonths);
$: updateOption("onOutsideClick", onOutsideClick);
$: updateOption("portal", portal);
</script>

<slot ids={$idValues} isInvalid={$localIsInvalid} />
3 changes: 3 additions & 0 deletions packages/bits-ui/src/lib/bits/date-range-picker/components/date-range-picker.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

type $$Props = Props;

export let portal: $$Props["portal"] = undefined;
export let value: $$Props["value"] = undefined;
export let onValueChange: $$Props["onValueChange"] = undefined;
export let placeholder: $$Props["placeholder"] = undefined;
Expand Down Expand Up @@ -50,6 +51,7 @@
isDateDisabled,
fixedWeeks,
calendarLabel,
portal,
disabled,
granularity,
hideTimeZone,
Expand Down Expand Up @@ -216,6 +218,7 @@
$: updateOption("weekdayFormat", weekdayFormat);
$: updateOption("numberOfMonths", numberOfMonths);
$: updateOption("onOutsideClick", onOutsideClick);
$: updateOption("portal", portal);
</script>

<slot
Expand Down