Remove DateFormatter for HTTP headers, so we can use FoundationEssentials #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
requested changes
Jan 7, 2025
|
Really great PR overall, just some minor tweaks |
|
This will hopefully get merged into Foundation at some point. But while it isn't we can run with our own version. |
Joannis
approved these changes
Jan 8, 2025
This was referenced Jan 8, 2025
bcbod2002
pushed a commit
to bcbod2002/hummingbird
that referenced
this pull request
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've hidden date formatting behind two functions
Date.init(httpHeader:)andDate.httpHeaderas we still need the DateFormatter for Linux 5.xHTTPHeaderDateFormatStyletakes the parsing strategy implementation from the one recently merged into swift-aws-lambda-runtime from @t089.