Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow symlinks when reading a file's attributes #642

Merged
merged 3 commits into from
Dec 28, 2024
Merged

Conversation

Joannis
Copy link
Member

@Joannis Joannis commented Dec 26, 2024

Fixes #640

@Joannis Joannis requested a review from adam-fowler as a code owner December 26, 2024 11:22
Copy link

github-actions bot commented Dec 26, 2024

@Joannis Joannis enabled auto-merge (squash) December 27, 2024 09:03
Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not also follow the symlink to get the file's contents

@Joannis Joannis merged commit 53c231f into main Dec 28, 2024
7 checks passed
bcbod2002 pushed a commit to bcbod2002/hummingbird that referenced this pull request Feb 6, 2025
…#642)

* Follow symlinks when reading a file's attributes

* Fix up the formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileMiddleware provides an incorrect Content-Length when serving a file that is a symlink
2 participants