Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throwing RequestContext init from parent RequestContext #596

Merged
merged 9 commits into from
Oct 25, 2024
Merged

Throwing RequestContext init from parent RequestContext #596

merged 9 commits into from
Oct 25, 2024

Conversation

adam-fowler
Copy link
Member

No description provided.

@adam-fowler adam-fowler requested a review from Joannis as a code owner October 23, 2024 08:46
@adam-fowler adam-fowler marked this pull request as draft October 23, 2024 08:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 23, 2024 •
edited
Loading

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-10-25T08:45:22+00:00

Joannis
Joannis reviewed Oct 23, 2024
View reviewed changes
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really happy with this PR's shape

@adam-fowler adam-fowler marked this pull request as ready for review October 23, 2024 22:01
@adam-fowler adam-fowler merged commit 2f8c590 into main Oct 25, 2024
6 of 7 checks passed
@adam-fowler adam-fowler deleted the throwing-request-context-init branch October 25, 2024 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joannis Joannis Joannis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @Joannis