Ensure we are running on EventLoop after HBAsyncMiddleware #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #357 +/- ##
==========================================
- Coverage 84.64% 84.59% -0.05%
==========================================
Files 79 79
Lines 4845 4849 +4
==========================================
+ Hits 4101 4102 +1
- Misses 744 747 +3 ☔ View full report in Codecov by Sentry. |
Joannis
approved these changes
Jan 24, 2024
Came from #356. So glad to not have to deal with EventLoops anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next responder was being running in the same task as the async middleware, which could cause problems for routes and middleware after which assume we are still running on the EventLoop
This PR adds flatSubmits to ensure we are running on the correctly EventLoop