Added TLSChannelConfiguration with async callbacks

hummingbird-project · Feb 11, 2025 · 672f8b6 · 672f8b6
1 parent 1e8f9e2
commit 672f8b6
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/Sources/HummingbirdHTTP2/TLSChannelConfiguration.swift b/Sources/HummingbirdHTTP2/TLSChannelConfiguration.swift
@@ -18,6 +18,7 @@ import NIOSSL
 /// TLSChannel configuration
 public struct TLSChannelConfiguration: Sendable {
     public typealias CustomVerificationCallback = @Sendable ([NIOSSLCertificate], EventLoopPromise<NIOSSLVerificationResult>) -> Void
+
     // Manages configuration of TLS
     public var tlsConfiguration: TLSConfiguration
     /// A custom verification callback that allows completely overriding the certificate verification logic of BoringSSL.
@@ -38,6 +39,26 @@ public struct TLSChannelConfiguration: Sendable {
         self.tlsConfiguration = tlsConfiguration
         self.customVerificationCallback = customVerificationCallback
     }
+
+    ///  Initialize TLSChannel.Configuration
+    ///
+    /// For details on custom callback see swift-nio-ssl documentation
+    /// https://swiftpackageindex.com/apple/swift-nio-ssl/main/documentation/niossl/niosslcustomverificationcallback
+    /// - Parameters:
+    ///   - tlsConfiguration: TLS configuration
+    ///   - customAsyncVerificationCallback: A custom verification callback that allows completely overriding the
+    ///         certificate verification logic of BoringSSL.
+    public init(
+        tlsConfiguration: TLSConfiguration,
+        customAsyncVerificationCallback: @escaping @Sendable ([NIOSSLCertificate]) async throws -> NIOSSLVerificationResult
+    ) {
+        self.tlsConfiguration = tlsConfiguration
+        self.customVerificationCallback = { certificates, promise in
+            promise.completeWithTask {
+                try await customAsyncVerificationCallback(certificates)
+            }
+        }
+    }
 }
 
 /// TLSChannel configuration

diff --git a/Sources/HummingbirdTLS/TLSChannel.swift b/Sources/HummingbirdTLS/TLSChannel.swift
@@ -95,6 +95,7 @@ extension ServerChildChannel {
 /// TLSChannel configuration
 public struct TLSChannelConfiguration: Sendable {
     public typealias CustomVerificationCallback = @Sendable ([NIOSSLCertificate], EventLoopPromise<NIOSSLVerificationResult>) -> Void
+
     // Manages configuration of TLS
     public let tlsConfiguration: TLSConfiguration
     /// A custom verification callback that allows completely overriding the certificate verification logic of BoringSSL.
@@ -115,6 +116,26 @@ public struct TLSChannelConfiguration: Sendable {
         self.tlsConfiguration = tlsConfiguration
         self.customVerificationCallback = customVerificationCallback
     }
+
+    ///  Initialize TLSChannel.Configuration
+    ///
+    /// For details on custom callback see swift-nio-ssl documentation
+    /// https://swiftpackageindex.com/apple/swift-nio-ssl/main/documentation/niossl/niosslcustomverificationcallback
+    /// - Parameters:
+    ///   - tlsConfiguration: TLS configuration
+    ///   - customAsyncVerificationCallback: A custom verification callback that allows completely overriding the
+    ///         certificate verification logic of BoringSSL.
+    public init(
+        tlsConfiguration: TLSConfiguration,
+        customAsyncVerificationCallback: @escaping @Sendable ([NIOSSLCertificate]) async throws -> NIOSSLVerificationResult
+    ) {
+        self.tlsConfiguration = tlsConfiguration
+        self.customVerificationCallback = { certificates, promise in
+            promise.completeWithTask {
+                try await customAsyncVerificationCallback(certificates)
+            }
+        }
+    }
 }
 
 /// TLSChannel configuration