Better pipeline type hints ✨ #38049
Open
Better pipeline type hints ✨ #38049
+398
−72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The code is a bit bloated, but since |
imba-tjd
reviewed
May 10, 2025
| @@ -12,7 +12,7 @@ | |||
| # See the License for the specific language governing permissions and | |||
| # limitations under the License. | |||
| import subprocess | |||
| from typing import Union | |||
| from typing import Any, Dict, List, Union | |||
There was a problem hiding this comment.
From readme I see transformers supports py 3.9+. According to py doc, there is no need to use typing.Dict and List.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
With the power of
@overloadthis PR adds several features to make our pipelines more IDE-friendly (and as a bonus more Curosor, Copilot and autocompletion friendly).1. Correctly resolve pipeline
typein casetaskis specified for pipeline functionAs a result, we have pipeline-specific docs and method signatures fetched by IDE
2. Resolve ambiguities regarding the input and output types for pipelines
For example,
The part of the code is autogenerated and added to the
pipelines/__init__.py+ added CI check / fix