Skip to content

Llama4: remove redundant transpose of router_logits #37468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2025

Conversation

pbelevich
Copy link
Contributor

What does this PR do?

This PR removes redundant transpose of router_logits

Who can review?

cc @ArthurZucker

@github-actions github-actions bot marked this pull request as draft April 12, 2025 17:08
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. The CI will be paused while the PR is in draft mode. When it is ready for review, please click the Ready for review button (at the bottom of the PR page). This will assign reviewers and trigger CI.

@pbelevich pbelevich marked this pull request as ready for review April 12, 2025 17:09
Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thank you! These transposes all cancel out and can be removed.

@Rocketknight1 Rocketknight1 merged commit ecaeee6 into huggingface:main Apr 15, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants