Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] fix E721 warnings #36474

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[Style] fix E721 warnings #36474

wants to merge 10 commits into from

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Feb 28, 2025

What does this PR do?

Fix E721 Use is and is not for type comparisons and do not print config.hidden_size as a tuple.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@github-actions github-actions bot marked this pull request as draft February 28, 2025 08:17
@kashif kashif marked this pull request as ready for review February 28, 2025 08:19
@kashif kashif requested a review from eustlb February 28, 2025 08:19
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ping me whenever you're finished and I'll merge (and try rerunning the tests or rebasing to get rid of those CI errors)

@kashif
Copy link
Contributor Author

kashif commented Feb 28, 2025

i am good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants