Customize docstrings fast image processor #36466
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes an issue discussed here #36406 (comment)
Introduce a decorator to make fast image processors
init
andpreprocess
docstrings more accurate while still avoiding to override the base ones completely.The decorator adds the following functionalities:
customize_docstrings
decorator for bothinit
andpreprocess
at once.annotations
for detr etc.), acustom_preprocess_docstring
can also be specified.preprocess
method.defaults to self.kwargs
in the docs will be overriden by the actual kwarg default value in the init docstringunused_kwargs
as introduced in this PR Refactor siglip2 fast image processor #36406 will also be removedFor example, here are the docs for ConvNextFastImageProcessor before and after this PR:
Before init:
After init:
Before preprocess:
After preprocess:
Notice the difference in default values for init, the order of kwargs (the processor-specific kwarg crop_pct is at the top in init, and right after
images
in preprocess), and the doc of thesize
kwarg which is overriden by the given customized doc forsize
.cc @qubvel , @stevhliu for docs :)