Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FlashAttentionKwargs and seq_idx to flat collator #36456

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

garrett361
Copy link

@garrett361 garrett361 commented Feb 27, 2025

What does this PR do?

Adds additional, optional return values in DataCollatorWithFlattening as needed for padding-free training with particular models.

Relates to #35861 and #35941.

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@garrett361 garrett361 marked this pull request as draft February 27, 2025 16:23
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@garrett361 garrett361 force-pushed the flash-attn-kwargs-in-flat-collator branch from 1d732bf to f0113af Compare February 27, 2025 16:23
@garrett361 garrett361 mentioned this pull request Feb 27, 2025
5 tasks
@vasqu
Copy link
Contributor

vasqu commented Feb 27, 2025

I'd like to take a look as well when you think you're ready, so gladly ping then :)

@vasqu
Copy link
Contributor

vasqu commented Feb 27, 2025

cc @ArthurZucker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants