Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading zero3 weights #36455

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Fix loading zero3 weights #36455

wants to merge 8 commits into from

Conversation

muellerzr
Copy link
Contributor

What does this PR do?

#36335 broke zero3 weight loading because we can't do TP for it and it needs to be how the methods were done originally.

Related fixings: #36441

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker @SunMarc

@muellerzr muellerzr added the bug label Feb 27, 2025
@github-actions github-actions bot marked this pull request as draft February 27, 2025 16:03
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@muellerzr muellerzr marked this pull request as ready for review February 27, 2025 16:03
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks, can go in integration no? (integration/deepspeed)

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil
Copy link
Member

when is this gonna be merged ?

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks for iterating!

@IlyasMoutawwakil
Copy link
Member

thanks @muellerzr
failing tests seem to be coming from main, they first appeared when unsilenced in #36449

@muellerzr
Copy link
Contributor Author

Yeah @ArthurZucker needs to merge it b/c of failings :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants