Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error when using torch.compile and DataCollatorWithFlattening #36450

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

efsotr
Copy link
Contributor

@efsotr efsotr commented Feb 27, 2025

fix typerror in torch.compile: convert max_length to Python int

Fixes #35588 (comment)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@ArthurZucker

@github-actions github-actions bot marked this pull request as draft February 27, 2025 13:20
Copy link

Hi 👋, thank you for opening this pull request! The pull request is converted to draft by default. When it is ready for review, please click the Ready for review button (at the bottom of the PR page).

@Rocketknight1
Copy link
Member

cc @ArthurZucker for FA2!

@efsotr efsotr marked this pull request as ready for review February 27, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flash_attention_2 2.7.2.post1 seems to crash when using torch.compile and DataCollatorWithFlattening
2 participants