Fix model saving bug post training with tensor parallel in Accelerate #36434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bursteratom
force-pushed
the
tp-model_saving-fix
branch
from
2b9d0b4 to
df531d2
Compare
|
@kmehant Wondering what your thoughts are? |
This was referenced Feb 26, 2025
|
cc @ArthurZucker who's also doing a big TP refactor right now! |
bursteratom
force-pushed
the
tp-model_saving-fix
branch
2 times, most recently
from
c17e92e to
d4e4907
Compare
bursteratom
force-pushed
the
tp-model_saving-fix
branch
from
d4e4907 to
4460137
Compare
|
@ArthurZucker @kmehant Seems like I'm failing a couple of tests, but I'm struggling to find the root cause. Wondering if you two can kindly take a look? |
bursteratom
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, attempting to save model after training with tensor parallel in Accelerate gives the
RuntimeError: Attempted to access the data pointer on an invalid python storage, this is due to the state dict not properly gathered from the sharded tensors beforehand. This PR fixes the error, allowing for successful model saving.Big thank you to @SalmanMohammadi for the discussion!
Fixes # (issue)
#34194 (comment)
#36436
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.