Serialization in tokio thread instead of blocking thread, 50% reduction in latency for small models #767
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is a performance bug introduced first by the initial release of TEI. The embeddings are calculated in a std::thread, with the intend to not block the main backend. While this is a fine idea, it would be much better to do it in a threadPool. tokio_spawn_blocking is such a thread pool with lazy warmup, therefore its a good idea to just use the runtimes pool for that.
Running a small model yields around ~20% more performance, some cases also 50%. Also leads to 15% thoughput improvments for small models.
mainline
This branch
Fixes # (issue)
Before submitting
instasnapshots?Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.