Add integration tests for Gaudi #598
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
regisss
reviewed
Apr 22, 2025
There was a problem hiding this comment.
Same comment as for TGI: huggingface/text-generation-inference#3160 (review)
It seems some files are not formatted properly: https://github.com/huggingface/text-embeddings-inference/actions/runs/14595555222/job/40940476819?pr=598
|
Thanks, I fixed the linting issue! I converted the PR as a draft until we have the Gaudi 2 and 3 runners for the CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds an integration test for Gaudi, with the goal of eventually including it in the CI pipeline. The CI pipeline will be a scheduled nightly test to check that there is no regression in the Gaudi TEI image.
Unfortunately, while working on this, I discovered that TEI is not compatible with Gaudi 1. As a result, it’s currently not possible to enable CI for this test, since we’re still in the process of setting up a CI cluster for Gaudi 2.
This integration test starts a TEI image on HPU, embeds a sample text, and verifies that the resulting embedding matches the expected output.