[tests] clean the pipeline level group offloading tests #12330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DN6
reviewed
Sep 16, 2025
| # tiling is enabled and a forward pass is run, when accelerator streams are used, the execution order of | ||
| # the layers is not traced correctly. This causes errors. For apply group offloading to VAE, a | ||
| # warmup forward pass (even with dummy small inputs) is recommended. | ||
| exclude_modules = [] |
There was a problem hiding this comment.
Can't we just set directly? Why nested loops? Or even set them via group_offloading_kwargs?
exclude_modules = ["vae", "vqvae", "image_encoder"]There was a problem hiding this comment.
Just readability convenience.
Passing exclude_modules = ["vae", "vqvae", "image_encoder"] is a bit misleading for the test, IMO. We would still log an info if non-member components are passed, though:
However, I have simplified this in a commit:
exclude_modules = {"vae", "vqvae", "image_encoder"}
exclude_modules = list(exclude_modules & set(pipe.components.keys()))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#12283 should not have introduced a separate test for testing pipeline-level group offloading inference, as we already have one:
diffusers/tests/pipelines/test_pipelines_common.py
Line 2248 in f5c113e
This test modifies the existing
test_group_offloading_inference()test to make use of the pipeline-levelenable_group_offload().