-
Notifications
You must be signed in to change notification settings - Fork 5.9k
[LoRA] make lora alpha and dropout configurable #11467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@bot /style |
Style fixes have been applied. View the workflow run here. |
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@bot /style |
Style fixes have been applied. View the workflow run here. |
good point! I thought we handled inference, will revert |
@bot /style |
Style fixes have been applied. View the workflow run here. |
@sayakpaul I think we can merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Let's maybe add an empty commit to retrigger the CI before merging?
make
lora_alpha
andlora_dropout
configurable for lora training,if not provided, sets by default
lora_alpha
to the value of--rank
to maintain current behaviouredit: this PR will only make
lora_dropout
configurable until #11324 is merged to handle inference withlora_rank
!=lora_alpha