Mark test_layerwise_upcasting as is_flaky #11282
Closed
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlky
force-pushed
the
test-layerwise-casting
branch
from
7b58b1d to
6222f4d
Compare
hlky
changed the title
sayakpaul
reviewed
Apr 10, 2025
| @@ -1436,6 +1437,7 @@ def test_fn(storage_dtype, compute_dtype): | |||
| test_fn(torch.float8_e5m2, torch.float32) | |||
| test_fn(torch.float8_e4m3fn, torch.bfloat16) | |||
|
|
|||
| @is_flaky | |||
There was a problem hiding this comment.
If it's only for test_models_autoencoder_hunyuan_video.py, I would consider subclassing it inside AutoencoderKLHunyuanVideoTests and decorating it with is_flaky.
There was a problem hiding this comment.
These tests haven't been running on CI for a while due to the unclip issue so it is potentially flaky for other models too.
There was a problem hiding this comment.
Would prefer confirming that first before marking all tests as flaky when they appear to be not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
https://github.com/huggingface/diffusers/actions/runs/14371854670/job/40296313951?pr=11268#step:7:8122
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.