docs(echo): add TRL backend note for ECHO#844
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
68d89a2 to
822d5d2
Compare
burtenshaw
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
examples/echo_world_model/backends/trl.md, a design note showing how the ECHO objective maps onto TRL'sGRPOTrainer(the framework OpenEnv recommends for RL training), and links it in the example'sbackends table. ECHO ships SkyRL/Tinker/Foundry notes but not TRL, the HF-native path, so this closes that gap. Same propositional style as the existing
tinker.mdandfoundry-finetuning.mdnotes — it documentsthe pattern, it is not a shipped implementation.
Type of Change
Alignment Checklist
Before submitting, verify:
.claude/docs/PRINCIPLES.mdand this PR aligns with our principles.claude/docs/INVARIANTS.mdand no invariants are violated/pre-submit-pr(orbash .claude/hooks/lint.shand tests) and addressed all issues — docs-only, no code paths touchedRFC Status
Test Plan
Markdown-only: new
backends/trl.md+ one line in the README backends table. The note is consistent withecho_loss.pyand the mask mapping in the sibling backend docs. The example's existing unit tests stillpass unchanged (
6 passed, verified withpytest test_echo.py). The note is explicitly framed as a proposed pattern (following TRL PR #6003), not a runnable adapter.Claude Code Review