Fix double callback on throw #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using Mocks somehow? |
SomeoneWeird
force-pushed
the
fix-double-callback-2
branch
from
c2ae99a to
4d1d12a
Compare
|
Ok, got it working by abusing domains. |
|
+1 i like the solution, clever work on the test case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2 for context, I think this is the correct solution.
Not sure how I can make this test pass, as we need it to throw to unwind the stack, to make sure we can't end up back in Transport territory, but mocha catches that, and fails the test, as we can't handle it. Open to suggestions.