Skip to content

Add kg filter menu to design system and use it in kg explorer#2176

Open
edlu77 wants to merge 9 commits intodevelopfrom
KG-filter-menu-improvements
Open

Add kg filter menu to design system and use it in kg explorer#2176
edlu77 wants to merge 9 commits intodevelopfrom
KG-filter-menu-improvements

Conversation

@edlu77
Copy link
Copy Markdown
Contributor

@edlu77 edlu77 commented Mar 9, 2026

@edlu77 edlu77 self-assigned this Mar 9, 2026
@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 9, 2026

View your CI Pipeline Execution ↗ for commit b88a984

Command Status Duration Result
nx affected --targets=lint,test,compodoc --conf... ✅ Succeeded 3m 17s View ↗
nx affected --target=build,build-webcomponent,b... ✅ Succeeded 4m 59s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-23 21:17:49 UTC

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 9, 2026

🚀 Preview Deploy Report

✅ Successfully deployed preview here

Copy link
Copy Markdown
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @edlu77 - Thank you for getting this started, it's looking great! This will make the KG way more accessible. A few observations and questions:

Font sizes

In the preview, I'm seeing label medium in places where label small should be, so something may have bugged out! I noticed this on the navigation header breadcrumbs in the FTU explorer homepage and the KG Explorer. I also see it in the KG's metadata page in the select.

Image Image

KG keyboard navigation

For the filter menu, is it possible to attach our new search lists (implemented for CNS) that can be navigated via keyboard?

Additionally, regarding the old digital object search list with the tooltips in the listing. Angular does not recommend any other buttons other than checkboxes in lists for accessibility, so we can replace this pattern with a new search list as well.

Figma

Image

@edlu77
Copy link
Copy Markdown
Contributor Author

edlu77 commented Mar 10, 2026

@LibbyUX The font sizes look good on my end. Let me know if the issue comes back though!

The search list is the same as in the design system so it should be keyboard navigable.

@edlu77 edlu77 requested a review from axdanbol March 11, 2026 19:23
@LibbyUX LibbyUX self-requested a review March 11, 2026 19:43
LibbyUX
LibbyUX previously approved these changes Mar 11, 2026
Copy link
Copy Markdown
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, @edlu77 !

@LibbyUX LibbyUX linked an issue Mar 11, 2026 that may be closed by this pull request
4 tasks
@LibbyUX
Copy link
Copy Markdown
Contributor

LibbyUX commented Mar 11, 2026

@edlu77 - Definitely approved but I do have one more request, if we can squeeze it in: Can we turn on the category counting for the filter menu so we can see how many unique items we have for each filter category?

@LibbyUX LibbyUX self-requested a review March 23, 2026 21:38
Copy link
Copy Markdown
Contributor

@LibbyUX LibbyUX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Iconic. Katy will love this update. Thank you so much @edlu77 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter menu improvements

2 participants