Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QUERY: examples section (fixes #1906) #3002

Merged
merged 24 commits into from
Feb 24, 2025
Merged

QUERY: examples section (fixes #1906) #3002

merged 24 commits into from
Feb 24, 2025

Conversation

reschke
Copy link
Contributor

@reschke reschke commented Feb 16, 2025

No description provided.

@reschke reschke self-assigned this Feb 16, 2025
@reschke reschke requested a review from MikeBishop as a code owner February 16, 2025 19:44
@reschke reschke marked this pull request as draft February 16, 2025 19:45
MikeBishop
MikeBishop approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@MikeBishop MikeBishop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, these examples help flesh out different possible scenarios nicely.

@reschke reschke requested a review from MikeBishop February 19, 2025 20:43
@reschke reschke marked this pull request as ready for review February 19, 2025 20:43
@reschke
Copy link
Contributor Author

reschke commented Feb 19, 2025

I declare this as "ready". Let the bike shedding begin :-)

(and let's hope for help wrt JSONPath syntax)

@reschke reschke requested a review from royfielding February 19, 2025 20:44
@reschke reschke merged commit 3cf46e2 into main Feb 24, 2025
2 checks passed
@reschke reschke deleted the reschke/1906 branch February 24, 2025 20:30
@reschke
Copy link
Contributor Author

reschke commented Feb 24, 2025

See #1906

@reschke reschke mentioned this pull request Feb 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinthomson martinthomson Awaiting requested review from martinthomson

@mnot mnot Awaiting requested review from mnot

@MikeBishop MikeBishop Awaiting requested review from MikeBishop MikeBishop is a code owner

@royfielding royfielding Awaiting requested review from royfielding

Assignees

@reschke reschke

Labels
query-method
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reschke @MikeBishop