Skip to content

Proxy websockets#901

Closed
pft wants to merge 2 commits intohttp-party:masterfrom
pft:master
Closed

Proxy websockets#901
pft wants to merge 2 commits intohttp-party:masterfrom
pft:master

Conversation

@pft
Copy link
Copy Markdown

@pft pft commented Oct 15, 2024

Proxy websockets when --websocket is given.

Relevant issues

Fixes issue #142

I took the PR from @fabioimpe at #528, removed style changes (and made sure not to add any of my own), and removed the changes to the changeOrigin parameter.

And of course, I tested whether it worked, which it does.

@KernelDeimos
Copy link
Copy Markdown
Contributor

Is there any way to test this? This should have tests before I merge it, if a unit test for this is complex I'll do a manual test later.

@pft
Copy link
Copy Markdown
Author

pft commented Oct 17, 2024

Well, it relies on another server working with websockets. A unit test could be done, but would require quite a bit of work.

@github-actions
Copy link
Copy Markdown

This pull request has been inactive for 360 days

@KernelDeimos
Copy link
Copy Markdown
Contributor

#872 (another websocket impl) was merged. The changes from this PR are present in #933, with a modification so it adds the --websocket flag to the existing implementation.

@github-actions github-actions Bot removed the stale label Oct 18, 2025
@KernelDeimos
Copy link
Copy Markdown
Contributor

Merged #933. You should still get contribution credit on GitHub because I kept your commits in my modified branch and did a rebase-and-merge to preserve them. Also, please take a look at the unit test from that PR - you mentioned that testing the websockets server requires additional effort but I was able to put something together based on examples from other unit tests. Let me know if you see a way we can make this easier or if something should be documented better.

@pft
Copy link
Copy Markdown
Author

pft commented Nov 4, 2025

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants