feat(attr-sort): sort unknown attributes alphabetically #668
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
stale
bot
added
the
bot:stale
thedaviddias
added
the
keep-unstale
|
Heya @chrisguttandin - can you please resolve the conflicts so we can get this one merged? Thanks! |
chrisguttandin
force-pushed
the
sort-all-attributes
branch
from
68423d7 to
1dc1b87
Compare
|
Hi @coliff, I've rebased the branch on top of the current master. |
|
@coliff Is there anything I can do about the failing CI tasks? |
|
Sorry for the delay - I think we need @thedaviddias for assistance on this. |
|
Hi @coliff, should I maybe close this PR and create a new one with the same changes on top of the latest master? |
|
hey @chrisguttandin - sorry for the trouble. We appreciate the PR and your patience with this - I know you opened this a long while back! :-) Yes, I think closing it and making a new PR could be a good idea. I'll be sure to review it as soon as you do. I'm hoping we'll be able to get a new release of HTMLHint out soon. thanks again! |
Previously unknown attributes were just ignored. Now they get sorted alphabetically. BREAKING CHANGE: HTMLHint will now throw an error if unkown attributes are not sorted. fix htmlhint#661
chrisguttandin
force-pushed
the
sort-all-attributes
branch
from
489e364 to
84b2ca9
Compare
|
Okay, I rebased the branch on top of master. Could you please take a look, @coliff? |
Previously unknown attributes were just ignored. Now they get sorted alphabetically.
BREAKING CHANGE: HTMLHint will now throw an error if unkown attributes are not sorted.
fix #661
Short description of what this resolves:
This PR will make sure all attributes get sorted when using the attr-sorted rule. It will ensure that attributes linted with this rule will always get sorted the same way.
Please let me know if there is anything that should be changed to make this PR mergable.