Skip to content

Conversation

@joyeeon
Copy link
Collaborator

@joyeeon joyeeon commented Apr 5, 2025

๐Ÿ“ ๋ฏธ์…˜ ๋ฒˆํ˜ธ

3์ฃผ์ฐจ Misson 1,2,3

๐Ÿ“‹ ๊ตฌํ˜„ ์‚ฌํ•ญ

  • mission 1, 2, 3 ๊ตฌํ˜„
  • types ํŒŒ์ผ์— ๊ณต์šฉ ์ธํ„ฐํŽ˜์ด์Šค ์ด์šฉ
  • hooks์—์„œ Loading ํ›… ๊ด€๋ฆฌ
  • pages์™€ components๋กœ ํŽ˜์ด์ง€, ์ปดํฌ๋„ŒํŠธ ๋ถ„๋ฆฌ
  • layout์—์„œ ๋ผ์šฐํŒ… ๊ด€๋ จ ๊ตฌํ˜„

๐Ÿ“Ž ์Šคํฌ๋ฆฐ์ƒท

image image image

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋ ค๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์–ด ์žˆ๋‚˜์š”?
  • ๋กœ์ปฌ์—์„œ ์‹คํ–‰ํ–ˆ์„ ๋•Œ ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•˜์ง€ ์•Š๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฃผ์„์ด ์ œ๊ฑฐ๋˜์—ˆ๋‚˜์š”?
  • ์ฝ”๋“œ ์Šคํƒ€์ผ์ด ์ผ๊ด€์ ์ธ๊ฐ€์š”?

๐Ÿค” ์งˆ๋ฌธ ์‚ฌํ•ญ

tailwindcss ์˜ tailwind.config.js ๊ฐ€ ์ƒ๊ธฐ์ง€ ์•Š๋Š”๋ฐ ์–ด๋–ป๊ฒŒ ๋งŒ๋“ค ์ˆ˜ ์žˆ๋Š”๊ฑธ๊นŒ์š”..

Copy link
Member

@hyesngy hyesngy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!๐Ÿ‘๐Ÿ‘
์˜ํ™” ์นดํ…Œ๊ณ ๋ฆฌ๋ฅผ URL ํŒŒ๋ผ๋ฏธํ„ฐ(:category)๋กœ ๋ณ€์ˆ˜ํ™”ํ•œ ์ ‘๊ทผ ๋ฐฉ์‹์ด ์ธ์ƒ์ ์ž…๋‹ˆ๋‹ค!

์ด๋ฒˆ ์ฃผ ์›Œํฌ๋ถ์„ ํ†ตํ•ด useEffect, API ์—ฐ๋™, ๋ผ์šฐํŒ…๊ณผ ์ƒํƒœ ๊ด€๋ฆฌ๊นŒ์ง€ ๊ฒฝํ—˜ํ•ด๋ณด์…จ๋„ค์š”!
๊ณ„์†ํ•ด์„œ ์‹ค์Šต๊ณผ ํ•™์Šต์„ ๋ณ‘ํ–‰ํ•˜๋ฉฐ ์‹ค๋ ฅ์„ ์Œ“์•„๊ฐ€์‹œ๊ธธ ์‘์›ํ•ฉ๋‹ˆ๋‹ค!!๐Ÿ‘๐Ÿ‘

return (
<nav className={`
w-full h-12 flex items-center justify-between px-10
w-full h-12 flex items-center justif px-10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด ๋ถ€๋ถ„์— ์˜คํƒ€๊ฐ€ ๋‚œ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค...!!

Suggested change
w-full h-12 flex items-center justif px-10
w-full h-12 flex items-center justify-between px-10

const { data } = await axios.get(`https://api.themoviedb.org/3/movie/${id}/credits?language=ko-KR`,
{
headers: {
Authorization: token,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OAuth 2.0 ํ‘œ์ค€์— ๋”ฐ๋ผ ํ† ํฐ ํƒ€์ž…์„ ๋ช…์‹œํ•˜๋Š” "Bearer"๋ฅผ ์ ‘๋‘์–ด๋กœ ๋ถ™์—ฌ์ฃผ์„ธ์š”!

Suggested change
Authorization: token,
Authorization: `Bearer ${token}`,

`https://api.themoviedb.org/3/movie/${category}?language=ko-KR&page=${page}`,
{
headers: {
Authorization: token,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OAuth 2.0 ํ‘œ์ค€์— ๋”ฐ๋ผ ํ† ํฐ ํƒ€์ž…์„ ๋ช…์‹œํ•˜๋Š” "Bearer"๋ฅผ ์ ‘๋‘์–ด๋กœ ๋ถ™์—ฌ์ฃผ์„ธ์š”!

Suggested change
Authorization: token,
Authorization: `Bearer ${token}`,

`https://api.themoviedb.org/3/movie/${id}?language=ko-KR`,
{
headers: {
Authorization: token,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OAuth 2.0 ํ‘œ์ค€์— ๋”ฐ๋ผ ํ† ํฐ ํƒ€์ž…์„ ๋ช…์‹œํ•˜๋Š” "Bearer"๋ฅผ ์ ‘๋‘์–ด๋กœ ๋ถ™์—ฌ์ฃผ์„ธ์š”!

Suggested change
Authorization: token,
Authorization: `Bearer ${token}`,

@@ -0,0 +1,59 @@
import axios from "axios";
import { Detail } from "../types/details";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ด๋ ‡๊ฒŒ ํƒ€์ž…๋งŒ์„ importํ•˜๋Š” ๊ฒฝ์šฐ์—๋Š” import type ์œผ๋กœ ์‚ฌ์šฉํ•˜๊ฒŒ ๋˜๋ฉด, ์ปดํŒŒ์ผ ํ›„ js ํŒŒ์ผ์—์„œ ์•„์˜ˆ ์‚ฌ๋ผ์ ธ ์„ฑ๋Šฅ ๊ฐœ์„ ์—๋„ ๋„์›€์ด ๋˜๊ณ , ์ปดํŒŒ์ผ ์†๋„๋„ ๋นจ๋ผ์ง‘๋‹ˆ๋‹ค!

@hyesngy
Copy link
Member

hyesngy commented Apr 6, 2025

์งˆ๋ฌธ์‚ฌํ•ญ์„ ์ง€๊ธˆ ํ™•์ธํ–ˆ๋Š”๋ฐ, tailwindcss v4 ๋ถ€ํ„ฐ tailwind.config.js ํŒŒ์ผ๋Œ€์‹  css์—์„œ ์ง์ ‘ ์„ค์ •์„ ์ •์˜ํ•˜๋„๋ก ๋ณ€๊ฒฝ ๋˜์—ˆ์Šต๋‹ˆ๋‹ค! tailwindcss v4 ์—…๋ฐ์ดํŠธ ๊ด€๋ จ ๋‚ด์šฉ์€ ๊ณต์‹ ๋ฌธ์„œ๋‚˜ ๊ด€๋ จ ๊ธ€์„ ์ฐพ์•„๋ณด๋ฉด ์ž๋ฃŒ๊ฐ€ ๋งŽ์ด ๋‚˜์˜ค๋‹ˆ ์•Œ์•„๋ณด๋ฉด ๋„์›€์ด ๋  ๊ฒƒ์ž…๋‹ˆ๋‹ค!
tailwindcss ๊ณต์‹ ๋ธ”๋กœ๊ทธ : https://tailwindcss.com/blog/tailwindcss-v4

@joyeeon joyeeon merged commit 996382d into main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants