Skip to content

Conversation

@geg222
Copy link
Collaborator

@geg222 geg222 commented Apr 4, 2025

๐Ÿ“ ๋ฏธ์…˜ ๋ฒˆํ˜ธ

3์ฃผ์ฐจ Misson 1,2,3

๐Ÿ“‹ ๊ตฌํ˜„ ์‚ฌํ•ญ

  • TMDB api ๋ถˆ๋Ÿฌ์˜ค๊ธฐ
  • useEffect๋ฅผ ํ™œ์šฉํ•˜์—ฌ ์˜ํ™” ๋ฐ์ดํ„ฐ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๊ธฐ
  • ๋กœ๋”ฉ ์—๋Ÿฌ ์ฒ˜๋ฆฌ ๋ฐ ์—ฌ๋Ÿฌ๊ฐœ์˜ ํŽ˜์ด์ง€ ๋ผ์šฐํŒ… ์ฒ˜๋ฆฌ -> spinner, error
  • ์˜ํ™” ID๋ฅผ ํ™œ์šฉํ•˜์—ฌ, ์˜ํ™” ์ƒ์„ธ ํŽ˜์ด์ง€ ๋งŒ๋“ค๊ธฐ -> useParams

๐Ÿ“Ž ์Šคํฌ๋ฆฐ์ƒท

default.mov
แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-04-05 แ„‹แ…ฉแ„’แ…ฎ 10 57 38 แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-04-05 แ„‹แ…ฉแ„’แ…ฎ 10 57 49 แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-04-05 แ„‹แ…ฉแ„’แ…ฎ 10 57 59 แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2025-04-05 แ„‹แ…ฉแ„’แ…ฎ 10 58 30

โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • Merge ํ•˜๋ ค๋Š” ๋ธŒ๋žœ์น˜๊ฐ€ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์„ค์ •๋˜์–ด ์žˆ๋‚˜์š”?
  • ๋กœ์ปฌ์—์„œ ์‹คํ–‰ํ–ˆ์„ ๋•Œ ์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ•˜์ง€ ์•Š๋‚˜์š”?
  • ๋ถˆํ•„์š”ํ•œ ์ฃผ์„์ด ์ œ๊ฑฐ๋˜์—ˆ๋‚˜์š”?
  • ์ฝ”๋“œ ์Šคํƒ€์ผ์ด ์ผ๊ด€์ ์ธ๊ฐ€์š”?

๐Ÿค” ์งˆ๋ฌธ ์‚ฌํ•ญ

@geg222 geg222 requested a review from hyesngy April 4, 2025 14:02
@geg222 geg222 self-assigned this Apr 4, 2025
Copy link
Member

@hyesngy hyesngy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒ ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค!๐Ÿ‘๐Ÿ‘
์ „๋ฐ˜์ ์œผ๋กœ UI์— ์‹ ๊ฒฝ์„ ๋งŽ์ด ์จ์„œ ๊ตฌํ˜„ํ•˜์‹  ์ ์ด ๋‹๋ณด์ด๊ณ , ์˜ํ™” ์นดํ…Œ๊ณ ๋ฆฌ๋ฅผ URL ํŒŒ๋ผ๋ฏธํ„ฐ๋กœ ๋ณ€์ˆ˜ํ™”ํ•œ ์ ‘๊ทผ ๋ฐฉ์‹์ด ์ธ์ƒ์ ์ž…๋‹ˆ๋‹ค!

ํ˜„์žฌ ํŽ˜์ด์ง€ ์ด๋™ ์‹œ ์Šคํฌ๋กค ์œ„์น˜๊ฐ€ ์œ ์ง€๋˜๊ณ  ์žˆ๋Š”๋ฐ, ๋” ๋‚˜์€ UX๋ฅผ ๊ณ ๋ คํ•˜์—ฌ, ์ƒˆ ํŽ˜์ด์ง€๋กœ ์ด๋™ ์‹œ ์Šคํฌ๋กค์ด ์ž๋™์œผ๋กœ ๋งจ ์œ„๋กœ ์˜ฌ๋ผ๊ฐ€๋„๋ก ๊ตฌํ˜„ํ•ด๋ณด๋ฉด ์–ด๋–จ๊นŒ์š”!

์ด๋ฒˆ ์ฃผ ์›Œํฌ๋ถ์„ ํ†ตํ•ด useEffect, API ์—ฐ๋™, ๋ผ์šฐํŒ…๊ณผ ์ƒํƒœ ๊ด€๋ฆฌ๊นŒ์ง€ ๊ฒฝํ—˜ํ•ด๋ณด์…จ๋„ค์š”!
๊ณ„์†ํ•ด์„œ ์‹ค์Šต๊ณผ ํ•™์Šต์„ ๋ณ‘ํ–‰ํ•˜๋ฉฐ ์‹ค๋ ฅ์„ ์Œ“์•„๊ฐ€์‹œ๊ธธ ์‘์›ํ•ฉ๋‹ˆ๋‹ค!!๐Ÿ‘๐Ÿ‘

Comment on lines +49 to +56
if (isError) {
return (
<div className="flex flex-col items-center justify-center h-screen text-red-600 bg-red-50 px-6 py-12 rounded-lg shadow-lg mx-4 text-center">
<h2 className="text-3xl font-bold mb-4">์—๋Ÿฌ๊ฐ€ ๋ฐœ์ƒํ–ˆ์Šต๋‹ˆ๋‹ค</h2>
<p className="text-lg">์ž ์‹œ ํ›„ ๋‹ค์‹œ ์‹œ๋„ํ•ด์ฃผ์„ธ์š”.</p>
</div>
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—๋Ÿฌ ์ƒํƒœ UI๋„ ๋กœ๋”ฉ ์ƒํƒœ UI์ฒ˜๋Ÿผ ๋ณ„๋„์˜ ์ปดํฌ๋„ŒํŠธ๋กœ ๋ถ„๋ฆฌํ•˜์—ฌ ์žฌ์‚ฌ์šฉํ•˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์˜ํ™” ์ƒ์„ธ ํŽ˜์ด์ง€์—์„œ ๋ฐฐ๊ฒฝ ์ด๋ฏธ์ง€๋‚˜ ์˜ํ™” ์ •๋ณด, ๊ฐ๋… ๋ฐ ์ถœ์—ฐ์ง„ ๋ชฉ๋ก ๋“ฑ์„ ๋ณ„๋„์˜ ์ปดํฌ๋„ŒํŠธ๋กœ ๋ถ„๋ฆฌํ•˜๋ฉด ์ฝ”๋“œ์˜ ๊ฐ€๋…์„ฑ๊ณผ ์œ ์ง€๋ณด์ˆ˜์„ฑ์ด ํ–ฅ์ƒ๋  ๊ฒƒ ๊ฐ™์•„์š”!

@geg222 geg222 merged commit 7c202e5 into main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants