Skip to content

Conversation

@wantkdd
Copy link
Member

@wantkdd wantkdd commented Apr 4, 2025

πŸ“ λ―Έμ…˜ 번호

3μ£Όμ°¨ Misson 1,2,3

πŸ“‹ κ΅¬ν˜„ 사항

  • useEffectλ₯Ό μ‚¬μš©ν•˜μ—¬ μ˜ν™” 데이터 뢈러였기
  • λ‘œλ”© μ—λŸ¬ 처리 및 μ—¬λŸ¬ 개의 νŽ˜μ΄μ§€ λΌμš°νŒ… 처리
  • μ˜ν™” IDλ₯Ό ν™œμš©ν•˜μ—¬ μƒμ„ΈνŽ˜μ΄μ§€ λ§Œλ“€κΈ°

πŸ“Ž μŠ€ν¬λ¦°μƒ·

image
image
image

βœ… 체크리슀트

  • Merge ν•˜λ €λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯΄κ²Œ μ„€μ •λ˜μ–΄ μžˆλ‚˜μš”?
  • λ‘œμ»¬μ—μ„œ μ‹€ν–‰ν–ˆμ„ λ•Œ μ—λŸ¬κ°€ λ°œμƒν•˜μ§€ μ•Šλ‚˜μš”?
  • λΆˆν•„μš”ν•œ 주석이 μ œκ±°λ˜μ—ˆλ‚˜μš”?
  • μ½”λ“œ μŠ€νƒ€μΌμ΄ μΌκ΄€μ μΈκ°€μš”?

πŸ€” 질문 사항

Copy link
Member

@hyesngy hyesngy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€!πŸ‘πŸ‘
이번 μ£Ό μ›Œν¬λΆμ„ 톡해 useEffect, API 연동, λΌμš°νŒ…κ³Ό μƒνƒœ κ΄€λ¦¬κΉŒμ§€ κ²½ν—˜ν•΄λ³΄μ…¨λ„€μš”!
κ³„μ†ν•΄μ„œ μ‹€μŠ΅κ³Ό ν•™μŠ΅μ„ λ³‘ν–‰ν•˜λ©° μ‹€λ ₯을 μŒ“μ•„κ°€μ‹œκΈΈ μ‘μ›ν•©λ‹ˆλ‹€!!πŸ‘πŸ‘

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR에 .env 파일이 ν¬ν•¨λ˜μ–΄ μžˆλŠ”λ°, .gitignore에 μΆ”κ°€ν•˜κ³  PRμ—μ„œ μ œκ±°ν•΄μ£Όμ„Έμš”! API ν‚€λŠ” λΉ„κ³΅κ°œλ‘œ μœ μ§€ν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€!

Comment on lines +9 to +15
if (error) {
return (
<div className="text-center text-3xl font-bold text-red-500 flex justify-center items-center h-screen">
{error}
</div>
);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—λŸ¬ μƒνƒœ UI도 λ‘œλ”© μƒνƒœ UI처럼 λ³„λ„μ˜ μ»΄ν¬λ„ŒνŠΈλ‘œ λΆ„λ¦¬ν•˜μ—¬ μž¬μ‚¬μš©ν•˜λ©΄ 쒋을 것 κ°™μŠ΅λ‹ˆλ‹€!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detail-page νŒŒμΌμ—μ„œ λ°°κ²½ μ΄λ―Έμ§€λ‚˜ μ˜ν™” 정보 및 μΆœμ—°μ§„ 정보 등을 λ³„λ„μ˜ μ»΄ν¬λ„ŒνŠΈλ‘œ λΆ„λ¦¬ν•˜λ©΄ μ½”λ“œμ˜ 가독성과 μœ μ§€λ³΄μˆ˜μ„±μ΄ ν–₯상될 것 κ°™μ•„μš”!

@wantkdd wantkdd merged commit e4bb6f8 into main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants