Skip to content

Conversation

@woojo230
Copy link
Collaborator

πŸ“ λ―Έμ…˜ 번호

3μ£Όμ°¨ λ―Έμ…˜ 1,2,3

πŸ“‹ κ΅¬ν˜„ 사항

  • api μ—°κ²°
  • pageNation κ΅¬ν˜„
  • custom hook λ‚΄λΆ€ useEffect ν™œμš©
  • μ—λŸ¬μ²˜λ¦¬, λ‘œλ”©μ²˜λ¦¬
  • 데이터 없을 μ‹œ λŒ€μ²΄ ui κ΅¬ν˜„
  • router μ„€μ •
  • layout μ„€μ •

πŸ“Ž μŠ€ν¬λ¦°μƒ·

μŠ€ν¬λ¦°μƒ· 2025-03-31 143216

βœ… 체크리슀트

  • Merge ν•˜λ €λŠ” λΈŒλžœμΉ˜κ°€ μ˜¬λ°”λ₯΄κ²Œ μ„€μ •λ˜μ–΄ μžˆλ‚˜μš”?
  • λ‘œμ»¬μ—μ„œ μ‹€ν–‰ν–ˆμ„ λ•Œ μ—λŸ¬κ°€ λ°œμƒν•˜μ§€ μ•Šλ‚˜μš”?
  • λΆˆν•„μš”ν•œ 주석이 μ œκ±°λ˜μ—ˆλ‚˜μš”?
  • μ½”λ“œ μŠ€νƒ€μΌμ΄ μΌκ΄€μ μΈκ°€μš”?

πŸ€” 질문 사항

@woojo230 woojo230 self-assigned this Mar 31, 2025
Copy link
Member

@hyesngy hyesngy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€!πŸ‘πŸ‘
이번 μ£Ό μ›Œν¬λΆμ„ 톡해 useEffect, API 연동, λΌμš°νŒ…κ³Ό μƒνƒœ κ΄€λ¦¬κΉŒμ§€ κ²½ν—˜ν•΄λ³΄μ…¨λ„€μš”!
데이터가 μ—†λŠ” 경우의 폴백 μ²˜λ¦¬κΉŒμ§€ κ΅¬ν˜„μ΄ 잘 λ˜μ–΄ μžˆλ„€μš”! UXκΉŒμ§€ κ³ λ €ν•˜μ—¬ κ΅¬ν˜„ν•œ 점이 μΈμƒμ μž…λ‹ˆλ‹€!
κ³„μ†ν•΄μ„œ μ‹€μŠ΅κ³Ό ν•™μŠ΅μ„ λ³‘ν–‰ν•˜λ©° μ‹€λ ₯을 μŒ“μ•„κ°€μ‹œκΈΈ μ‘μ›ν•©λ‹ˆλ‹€!!πŸ‘πŸ‘

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR에 .env 파일이 ν¬ν•¨λ˜μ–΄ μžˆλŠ”λ°, .gitignore에 μΆ”κ°€ν•˜κ³  PRμ—μ„œ μ œκ±°ν•΄μ£Όμ„Έμš”! API ν‚€λŠ” λΉ„κ³΅κ°œλ‘œ μœ μ§€ν•˜λŠ” 것이 μ’‹μŠ΅λ‹ˆλ‹€!

import DetailTop from '../components/movie-detail/DetailTop';
import DetailBottom from '../components/movie-detail/DetailBottom';
import { useQuery } from '@tanstack/react-query';
import { CastDataType, MovieDetailDataType } from '../type/type';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ΄λ ‡κ²Œ νƒ€μž…λ§Œμ„ importν•˜λŠ” κ²½μš°μ—λŠ” import type 으둜 μ‚¬μš©ν•˜κ²Œ 되면, 컴파일 ν›„ js νŒŒμΌμ—μ„œ μ•„μ˜ˆ 사라져 μ„±λŠ₯ κ°œμ„ μ—λ„ 도움이 되고, 컴파일 속도도 λΉ¨λΌμ§‘λ‹ˆλ‹€!

@woojo230 woojo230 merged commit d98803c into main Apr 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants