Skip to content

bugfix: add validation for date range format to prevent undefined rep… #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
6-keem merged 1 commit into from
Mar 13, 2025
Merged

bugfix: add validation for date range format to prevent undefined rep… #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/hooks/useCourseData.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export function useCourseData(courses: any[]) {
setIsPending(false);
} catch (error) {
localStorage.removeItem('lastRequestTime');
// setIsError(true);
setIsError(true);
setIsPending(false);
}
}, [courses]);
Expand Down
14 changes: 12 additions & 2 deletions src/lib/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,27 @@ export function cn(...inputs: ClassValue[]) {
return twMerge(clsx(inputs));
}

export function isCurrentDateInRange(dateRange: string) {
export function isCurrentDateInRange(dateRange: string | null) {
if (!dateRange || !dateRange.includes(' ~ ')) {
return false;
}

const [startStr, endStr] = dateRange.split(' ~ ');

if (!startStr || !endStr) {
return false;
}

const startDate = new Date(startStr.replace(/-/g, '/'));
const endDate = new Date(endStr.replace(/-/g, '/'));

const currentDate = new Date();

return currentDate >= startDate && currentDate <= endDate;
}
export function isCurrentDateByDate(date: string) {

export function isCurrentDateByDate(date: string | null) {
if (!date || date.length <= 1) return false;
const endDate = new Date(date);
const currentDate = new Date();
return currentDate <= endDate;
Expand Down
Loading