Some fix-ups for macOS#3
Open
barracuda156 wants to merge 3 commits into
Open
Conversation
Fixes: hrs-allbsd#2 Apple headers conflict here. See: https://github.com/greenplum-db/gpdb/commit/ca7608915e6caaa2a06b727b7f93e154b0abf88d
Closes: hrs-allbsd#1
Author
|
Builds fine with these fixes for all macOS (I have also locally confirmed PowerPC build): https://ports.macports.org/port/spegla/details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P. S. I have dropped the define
NO_STRLCPYsince it becomes redundant in the sources. It also makes little sense to require a manual define for a common case. A special case is macOS with clang, where a conflict with system headers arises. Even on macOS itself with GCC the build is fine.