Add option to choose whether the deleted region should be added to kill ring #14
Conversation
There was a problem hiding this comment.
OK, I suggest the following:
- create a new clean branch/PR
- use a custom variable
smart-hungry-delete-kill-functionthat holds a function symbol to eitherkill-regionordelete-regionwith a DOCSTRING like "A function symbol to kill the buffer text thatsmart-hungry-deletedecides to delete or kill.\n\nThe function is called with two buffer positionsBEGENDas its only parameters and should remove the buffer text between these positions." - just use that function in
smart-hungry-delete-char
I think that's much cleaner, do you agree? Or am I missing something?
(Oh, and I'm sorry it takes so long for me to get back to the PRs 😬 )
| @@ -61,6 +61,12 @@ | |||
| :safe t | |||
| ) | |||
|
|
|||
| (defcustom smart-hungry-delete-add-kill-ring t | |||
There was a problem hiding this comment.
Hmm, I don't want to be annoying, but can we rename this to smart-hungry-delete-kill-ring-save just like kill-ring-save? Or were you inspired by some other existing variable/function name? There's also avy-kill-ring-save-region and org-export-copy-to-kill-ring.
| @@ -124,6 +130,14 @@ completely deleted." | |||
| (add-hook 'nxml-mode-hook 'smart-hungry-delete-default-sgml-mode-common-hook) | |||
| (add-hook 'text-mode-hook 'smart-hungry-delete-default-text-mode-hook)) | |||
|
|
|||
| ;;;###autoload | |||
| (defun smart-hungry-delete-should-add-kill-ring (should-kill) | |||
There was a problem hiding this comment.
common elisp convention is to postfix predicate functions with -p: e.g. -any-p, ring-p, org-url-p.
How about smart-hungry-delete-kill-ring-save-p?
There was a problem hiding this comment.
Wait, this isn't a predicate. Hmm.
| ([remap delete-backward-char] . smart-hungry-delete-backward-char) | ||
| ([remap delete-char] . smart-hungry-delete-forward-char)) | ||
| :init (smart-hungry-delete-add-default-hooks)) | ||
| ([remap delete-backward-char] . smart-hungry-delete-backward-char) |
There was a problem hiding this comment.
Can you provide these in a separate PR?
| @@ -124,6 +130,14 @@ completely deleted." | |||
| (add-hook 'nxml-mode-hook 'smart-hungry-delete-default-sgml-mode-common-hook) | |||
| (add-hook 'text-mode-hook 'smart-hungry-delete-default-text-mode-hook)) | |||
|
|
|||
| ;;;###autoload | |||
| (defun smart-hungry-delete-should-add-kill-ring (should-kill) | |||
| "Choose deleted region should be added to kill ring or not by `SHOULD-KILL`." | |||
There was a problem hiding this comment.
"Should the deleted region be added to the KILL-RING?"
| "Choose deleted region should be added to kill ring or not by `SHOULD-KILL`." | ||
| (interactive) | ||
| (setq smart-hungry-delete-add-kill-ring should-kill) | ||
| (put #'smart-hungry-delete-backward-char 'delete-selection (if smart-hungry-delete-add-kill-ring 'kill nil)) |
There was a problem hiding this comment.
Why are you putting stuff into the fsymbol here? It's never used, is it?
|
Thx for the review!! 🤝 |
|
Sure, I'm happy to review when you find the time, thanks for submitting! <3 |
This package is very useful 🎉
I'll suggest one more feature: related #13 , #12
What's this PR
Add
smart-hungry-delete-should-add-kill-ringmethod to choose whether deleted region should be added tokill ringor not.Usage
Usage is as follows.