Fixed getTokenWithCardNumber method not resuming the created NSURLSessionDataRequest#36
Open
HernanPaez wants to merge 1 commit intohps:masterfrom
Open
Fixed getTokenWithCardNumber method not resuming the created NSURLSessionDataRequest#36HernanPaez wants to merge 1 commit intohps:masterfrom
HernanPaez wants to merge 1 commit intohps:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered that the card tokenization service was not working.
Under further investigation I found that the getTokenWithCardDictionary method wasn't sending the request to the remote server because it was missing the resume method call on the NSURLSessionDataTask.
This caused the library to don't make the request to Heartland's servers and therefore the app never had a response from the tokenization service.
I added the resume call and the service is working as intended.