Address warnings

hpi-swa · Jan 3, 2025 · 4c87f28 · 4c87f28
1 parent 56011ba
commit 4c87f28
Show file tree

Hide file tree

Showing 9 changed files with 9 additions and 2 deletions.
diff --git a/src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/model/AbstractSqueakObject.java b/src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/model/AbstractSqueakObject.java
@@ -126,7 +126,7 @@ protected static final Object doSendGeneric(final Node node, final AbstractSquea
                         @Cached final LookupMethodNode lookupNode,
                         @Cached final SqueakObjectClassNode classNode,
                         @Shared("wrapNode") @Cached final WrapToSqueakNode wrapNode,
-                        @Cached final IndirectCallNode callNode) throws Exception {
+                        @Cached(inline = false) final IndirectCallNode callNode) throws Exception {
             final SqueakImageContext image = SqueakImageContext.get(node);
             if (message.getLibraryClass() == InteropLibrary.class) {
                 final NativeObject selector = image.toInteropSelector(message);

diff --git a/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector0Node.java b/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector0Node.java
@@ -109,6 +109,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector1Node.java b/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector1Node.java
@@ -110,6 +110,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver, final Object arg1,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector2Node.java b/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector2Node.java
@@ -112,6 +112,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver, final Object arg1, final Object arg2,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector3Node.java b/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector3Node.java
@@ -114,6 +114,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver, final Object arg1, final Object arg2, final Object arg3,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector4Node.java b/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector4Node.java
@@ -116,6 +116,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver, final Object arg1, final Object arg2, final Object arg3, final Object arg4,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector5Node.java b/....swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelector5Node.java
@@ -119,6 +119,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver, final Object arg1, final Object arg2, final Object arg3, final Object arg4, final Object arg5,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/...a.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelectorNaryNode.java b/...a.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/DispatchSelectorNaryNode.java
@@ -127,6 +127,7 @@ protected static final Object doDirect(final VirtualFrame frame, final Object re
 
         @ReportPolymorphism.Megamorphic
         @Specialization(replaces = "doDirect")
+        @SuppressWarnings("truffle-static-method")
         protected final Object doIndirect(final VirtualFrame frame, final Object receiver, final Object[] arguments,
                         @Bind("this") final Node node,
                         @Cached final SqueakObjectClassNode classNode,

diff --git a/src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/SenderNode.java b/src/de.hpi.swa.trufflesqueak/src/de/hpi/swa/trufflesqueak/nodes/dispatch/SenderNode.java
@@ -36,7 +36,7 @@ protected static final Object doContextOrMarker(final VirtualFrame frame,
     @Specialization(replaces = "doContextOrMarker")
     protected static final Object doContext(final VirtualFrame frame,
                     @Bind("this") final Node node,
-                    @Cached final GetOrCreateContextNode getOrCreateContextNode) {
+                    @Cached(inline = true) final GetOrCreateContextNode getOrCreateContextNode) {
         return getOrCreateContextNode.executeGet(frame, node);
     }
 }