Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HPCC-33717 Generic Disk Write Subtask: Prep interfaces #19655

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

HPCC-33717 Generic Disk Write Subtask: Prep interfaces #19655

wants to merge 2 commits into from

Conversation

dcamper
Copy link
Contributor

@dcamper dcamper commented Mar 21, 2025

Maintain backwards compatibility

Type of change:

  • This change is a bug fix (non-breaking change which fixes an issue).
  • This change is a new feature (non-breaking change which adds functionality).
  • This change improves the code (refactor or other change that does not change the functionality)
  • This change fixes warnings (the fix does not alter the functionality or the generated code)
  • This change is a breaking change (fix or feature that will cause existing behavior to change).
  • This change alters the query API (existing queries will have to be recompiled)

Checklist:

  • My code follows the code style of this project.
    • My code does not create any new warnings from compiler, build system, or lint.
  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit is signed.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly, or...
    • I have created a JIRA ticket to update the documentation.
    • Any new interfaces or exported functions are appropriately commented.
  • I have read the CONTRIBUTORS document.
  • The change has been fully tested:
    • I have added tests to cover my changes.
    • All new and existing tests passed.
    • I have checked that this change does not introduce memory leaks.
    • I have used Valgrind or similar tools to check for potential issues.
  • I have given due consideration to all of the following potential concerns:
    • Scalability
    • Performance
    • Security
    • Thread-safety
    • Cloud-compatibility
    • Premature optimization
    • Existing deployed queries will not be broken
    • This change fixes the problem, not just the symptom
    • The target branch of this pull request is appropriate for such a change.
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised JIRA issues to address them separately
  • This is a user interface / front-end modification
    • I have tested my changes in multiple modern browsers
    • The component(s) render as expected

Smoketest:

  • Send notifications about my Pull Request position in Smoketest queue.
  • Test my draft Pull Request.

Testing:

@dcamper
HPCC-33717 Generic Disk Write: Prep interfaces
7583204 
Maintain backwards compatibility
@dcamper dcamper requested a review from ghalliday March 21, 2025 17:43
@github-actions GitHub Actions
Copy link

Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-33717

Jirabot Action Result:
Workflow Transition To: Merge Pending
Updated PR

ghalliday
ghalliday reviewed Mar 27, 2025
View reviewed changes
Copy link
Member

@ghalliday ghalliday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dcamper a couple of comments/questions.
I also (separately) wonder whether the IHThorGenericDiskWriteArg interface should be merged into IHThorDiskWriteArg. It doesn't matter either way, and is independent of this PR.

ecl/hqlcpp/hqlhtcpp.cpp Outdated
@@ -10991,6 +10994,8 @@ ABoundActivity * HqlCppTranslator::doBuildActivityOutput(BuildCtx & ctx, IHqlExp
Owned<ActivityInstance> instance = new ActivityInstance(*this, ctx, kind, expr, activityArgName);
//Output to a variable filename is either a user result, or a computed workflow spill, both need evaluating.

instance->setUseGenericReadWrite(useGenericReadWrites);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure what this is here for, or why this needs to be tracked in the instance. It is currently unused.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am still learning how this framework operates and believed that I needed to propagate that boolean. I will remove it.

ecl/hqlcpp/hqlcpp.cpp
@@ -1908,7 +1908,7 @@ void HqlCppTranslator::cacheOptions()
DebugOption(options.checkDuplicateMinActivities, "checkDuplicateMinActivities", 100),
DebugOption(options.diskReadsAreSimple, "diskReadsAreSimple", false), // Not yet enabled - needs filters to default to generating keyed info first
DebugOption(options.allKeyedFiltersOptional, "allKeyedFiltersOptional", false),
DebugOption(options.genericDiskReads, "genericDiskReads", false), // Can be enabled for hthor, but locking not currently supported
DebugOption(options.genericDiskReadWrites, "genericDiskReadWrites", false), // Can be enabled for hthor, but locking not currently supported
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ecl files that define genericDiskReads need to be updated to match.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ECL files updated.

ecl/hqlcpp/hqlhtcpp.cpp Outdated
@@ -10916,6 +10916,9 @@ ABoundActivity * HqlCppTranslator::doBuildActivityOutput(BuildCtx & ctx, IHqlExp
IHqlExpression * dataset = expr->queryChild(0);
IHqlExpression * rawFilename = queryRealChild(expr, 1);

// Determine if we should use generic read/write code
bool useGenericReadWrites = options.genericDiskReadWrites && targetHThor();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for the hthor test - that should be already covered in hqlcpp(2032) above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This variable was removed entirely as it is no longer used.

@dcamper
Copy link
Contributor Author

dcamper commented Mar 27, 2025

@dcamper a couple of comments/questions. I also (separately) wonder whether the IHThorGenericDiskWriteArg interface should be merged into IHThorDiskWriteArg. It doesn't matter either way, and is independent of this PR.

I thought the same, and I do think that it would simplify the changes (where simplify == fewer changes).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghalliday ghalliday ghalliday left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcamper @ghalliday