-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HPCC-31540 Restore Workunits (DFU and ECL) Functionality #19619
base: candidate-9.8.x
Are you sure you want to change the base?
Conversation
Jira Issue: https://hpccsystems.atlassian.net//browse/HPCC-31540 Jirabot Action Result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kunalaswani Should change those console.log/error to use our logger equivalents. Looked good otherwise
@kunalaswani Github commented in your changed files about errors that prevented it from building in npm |
Restores ECL & DFU Workunits via the sasha front end. Signed-off-by: Kunal Aswani <[email protected]>
@GordonSmith is this the correct version to target? Should ti be targeting 9.2.x instead? |
@ghalliday Looks like the WsSasha service only exists in 9.6 and newer, so should target 9.6.x instead of 9.8.x @kunalaswani? Same answer for #19619 as well. |
Restores ECL & DFU Workunits via the sasha front end.
Type of change:
Checklist:
Smoketest:
Testing: