Skip to content

[ci] Fix potential github action smells #5668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ci] Fix potential github action smells #5668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build_on_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ jobs:

- name: Upload test coverage artifact
uses: actions/upload-artifact@v3
if: success()
with:
name: report
path: report/
1 change: 1 addition & 0 deletions .github/workflows/compatiblity_test_on_schedule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ jobs:
matrix_preparation:
name: Prepare Container List
runs-on: ubuntu-latest
if: ${{github.event_name != 'schedule' || github.repository == 'hpcaitech-colossalai'}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the repo be hpcaitech/ColossalAI? And why not run when the event name is schedule?

outputs:
matrix: ${{ steps.set-matrix.outputs.matrix }}
steps:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/draft_github_release_post_after_merge.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
name: Draft Release Post
if: ( github.event_name == 'workflow_dispatch' || github.event.pull_request.merged == true ) && github.repository == 'hpcaitech/ColossalAI'
runs-on: ubuntu-latest
permissions:
contents: write
steps:
- uses: actions/checkout@v2
with:
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/report_test_coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ jobs:
report-test-coverage:
runs-on: ubuntu-latest
if: ${{ github.event.workflow_run.conclusion == 'success' }}
permissions:
contents: write
steps:
- name: "Download artifact"
uses: actions/github-script@v6
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/submodule.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ jobs:
sync-submodule:
runs-on: ubuntu-latest
if: github.repository == 'hpcaitech/ColossalAI'
permissions:
contents: write
pull-requests: write
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down