fix: Error when min_level to low #337
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Previously, we could have min_level too low for the MPI comm size. This could lead to an unhandled error. - Here is a workaround to ensure the user avoids the error. - In the future, we could resolve the primary issue and then remove this workaround
gouarin
force-pushed
the
error_when_lots_ranks
branch
from
aee2499 to
d498379
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix MPI decomposition issue by enforcing a minimum min_level when MPI size is too large.
Related issue
Segfault error
How has this been tested?
with advection-2d with different MPI comm size
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct