fix: Update level_cell_array.hpp #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the constructor from subset node so that it uses `LevelCellArray::add_interval` instead of creating a temporary `LevelCellList`
alexandrehoffmann
changed the title
gouarin
reviewed
Mar 13, 2025
include/samurai/level_cell_array.hpp
Outdated
| { | ||
| lcl[index].add_interval(i); | ||
| add_interval_back({i.start, i.end}, index); |
There was a problem hiding this comment.
Why you can't put i directly ?
gouarin
reviewed
Mar 14, 2025
include/samurai/level_cell_array.hpp
Outdated
Comment on lines
447
to
448
| const value_t xmin = x_interval.start; | ||
| const value_t xmax = x_interval.end; |
There was a problem hiding this comment.
We probably can remove now xmin and xmax and only work with x_interval, no ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated the constructor of
LevelCellArrayfromSubsetso that it usesLevelCellArray::add_interval_backinstead of creating a temporaryLevelCellList.Plus
add_interval_back_rechas been modified so thaty_offsetis properly initialized when them_cellsis empty.Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct