fix: simplifies, fixes and documents left and right shift of Interval #172
+152
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It shows issues with right shift of 0 and 2 steps (and probably above).
The right shift algorithm can be simplified using a one line code, that is also more robust (for shift other than 1). The formula is explained and justified in the documentation of Interval.
rolanddenis
force-pushed
the
fix_interval_shift
branch
from
54def06 to
f848150
Compare
gouarin
pushed a commit
that referenced
this pull request
Feb 29, 2024
🤖 I have created a release *beep* *boop* --- ## [0.10.0](v0.9.0...v0.10.0) (2024-02-29) ### Features * add dim in field_operator_base ([#168](#168)) ([d74b6ca](d74b6ca)) * additional initial value parameter to make_field ([#162](#162)) ([3536eac](3536eac)) * Boundary conditions with configurable stencil ([#167](#167)) ([e59c2a4](e59c2a4)) * collapsable flux value in non-linear flux-based schemes ([#165](#165)) ([bca0474](bca0474)) * const field in FV operator lambdas ([#164](#164)) ([7a78d2b](7a78d2b)) * local newton solvers ([#153](#153)) ([699468e](699468e)) * Non-conservative fluxes ([#161](#161)) ([61d1cfd](61d1cfd)) * Parallelization using MPI ([#28](#28)) ([a411c76](a411c76)) * use xexpression for get_interval, get_index and get_cell ([#170](#170)) ([9391d2d](9391d2d)) * WENO5 scheme ([#166](#166)) ([55fe777](55fe777)) ### Bug Fixes * cell array instead of cell xtensor for the stencil of non-linear cell-based schemes ([#156](#156)) ([2487af3](2487af3)) * Fix flux-based schemes with unsymmetric stencil ([#157](#157)) ([697cca6](697cca6)) * Fix operators for time integration ([#154](#154)) ([7993525](7993525)) * fixing (almost) all warnings triggered when compiling tests & demos ([#163](#163)) ([246ebcb](246ebcb)) * right shift on interval ([#169](#169)) ([67f84e1](67f84e1)) * simplifies, fixes and documents left and right shift of Interval ([#172](#172)) ([db8ce1c](db8ce1c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Available tags: 'build', 'chore', 'ci', 'docs', 'feat', 'fix', 'perf', 'refactor', 'revert', 'style', 'test'
Description
There was some issues with current implementation of right shift of an
Interval:This PR adds a more thorough test of
Interval's left and right shift and implements a new formula for the right shift that is consistent with previous behaviour for unitary step and fixes the others steps.The formula is explained and justified in the documentation.
How has this been tested?
Thorough test in
test_interval.cpp.Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct