24751: Adds passthrough to memory-based save/load #582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmaze
reviewed
Jan 27, 2026
Contributor
dmaze
left a comment
dmaze
left a comment
There was a problem hiding this comment.
I'd like to see room for other clients besides the direct client to support this.
If it's not hard, the counterpart to this is creating a trainee from bytes (HowsoDirectClient.create_trainee_from_memory()) and it might be nice to see higher-level support for that too. This should let you round-trip a trainee by dumping it to memory (and deleting it it you want) and then reloading it.
| The Trainee file data as bytes. Or None if the `trainee_id` and/or `trainee_path` does not refer to | ||
| a valid Trainee. | ||
| """ | ||
| if not isinstance(self.client, HowsoDirectClient): |
Contributor
There was a problem hiding this comment.
I might prefer to condition this on the existence of the trainee_to_memory method, or use a runtime-checkable protocol.
@runtime_checkable
class CanLoadSaveMemory(Protocol):
def trainee_to_memory(self, id: str, file_type: Literal["amlg", "caml"], trainee_path: something) -> bytes | None: ...
if isinstance(self.client, CanLoadSaveMemory):
return self.client.trainee_to_memory(...)
raise NotImplementedError
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.