Skip to content

24954: Fixes crash in sbfds #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
howsoRes merged 1 commit into from
Jan 20, 2026
Merged

24954: Fixes crash in sbfds #488

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Amalgam/SBFDSColumnData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ void SBFDSColumnData::ChangeIndexValue(EvaluableNodeImmediateValueType new_value
{
auto [new_size_entry, inserted] = valueCodeSizeToIndices.emplace(new_code_size, nullptr);

//need to emplace above before searching to ensure new_size_entry does not become invalidated
auto old_size_entry = valueCodeSizeToIndices.find(old_code_size);
if(old_size_entry == end(valueCodeSizeToIndices))
{
Expand All @@ -387,7 +388,7 @@ void SBFDSColumnData::ChangeIndexValue(EvaluableNodeImmediateValueType new_value
//TODO 24298: ensure index size is always correct and updated so entities won't be missed, remove this code and assert false if not found
for(auto cur_id_entry = begin(valueCodeSizeToIndices); cur_id_entry != end(valueCodeSizeToIndices); ++cur_id_entry)
{
if(cur_id_entry->second->contains(index))
if(cur_id_entry->second != nullptr && cur_id_entry->second->contains(index))
{
old_size_entry = cur_id_entry;
break;
Expand Down