Repository navigation
Bump golangci-lint to v2.14.0 so lint runs on Go 1.27.2 - #297
Merged
Merged
Conversation
setup-go resolves 'go 1.27' to the newest patch, and Go 1.27.2 writes export data version 5. golangci-lint v2.13.x reads only up to version 4, so every package failed typecheck and lint went red on main with no code change. v2.14.0 reads version 5 and lints clean on 1.27.1 and 1.27.2. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ChkEQYvmpnbbwxzowHsaSh
Benchmark report (advisory)Statistically significant changes: 9 regression(s), 17 improvement(s) (PR head vs. base branch).
Higher is worse on every metric. Full benchstat table |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by ovsep · project thread
Before: CI has been red on main since 2026-10-09. The golangci-lint step fails typecheck on every package with "export data version 5 is greater than maximum supported version 4". The tests pass.
After: lint runs clean, so CI and the badge go green.
go.modsaysgo 1.27, so setup-go installs the newest 1.27.x. That was 1.27.1 on the last green run and 1.27.2 on the failing one. Go 1.27.2 writes export data that golangci-lint v2.13.x can't read. No code change caused this.How: the pinned linter version in
.github/workflows/ci.ymlgoes from v2.13.1 to v2.14.0. I tested this locally. v2.13.1 and v2.13.2 reproduce the failure under Go 1.27.2, and rebuilding v2.13.1 from source with 1.27.2 doesn't help either. v2.14.0 reports 0 issues under both 1.27.1 and 1.27.2, andmake checkpasses under 1.27.2.🤖 Generated with Claude Code
https://claude.ai/code/session_01ChkEQYvmpnbbwxzowHsaSh
Generated by Claude Code