-
Notifications
You must be signed in to change notification settings - Fork 4
김미수 과제 #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Misu0616
wants to merge
1
commit into
house-study:main
Choose a base branch
from
Misu0616:react
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−12
Open
김미수 과제 #7
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,23 @@ | ||
| import React from "react"; | ||
| import React, { useState } from "react"; | ||
| import "./index.css"; | ||
|
|
||
| // Counter의 시작은 0부터 시작합니다. | ||
| const Counter = () => { | ||
| const [num, setNum] = useState(0); | ||
|
|
||
| const countChange = (e) => { | ||
| const countN = num + e; | ||
|
|
||
| if(countN >= -10 && countN <= 10){ | ||
| setNum(countN); | ||
| } | ||
| }; | ||
| return ( | ||
| <div className="counter--container"> | ||
| <button>-</button> | ||
| <p>{/** 여기에 카운트가 나타납니다. 주석 삭제 후 작성해주세요 */}</p> | ||
| <button>+</button> | ||
| <button onClick={() => countChange(-1)}>-</button> | ||
| <p>{num}</p> | ||
| <button onClick={() => countChange(+1)}>+</button> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default Counter; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,11 @@ | ||
| import React from "react"; | ||
|
|
||
| const Input = () => { | ||
| return <input />; | ||
| const Input = ({onChange, value}) => { | ||
| return (<input | ||
| value={value} | ||
| onChange={onChange} | ||
| /> | ||
| ); | ||
| }; | ||
|
|
||
| export default Input; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,16 +1,24 @@ | ||
| import React from "react"; | ||
| import React, { useState } from "react"; | ||
| import "./index.css"; | ||
| import Input from "../Input"; | ||
|
|
||
| const ShowBox = () => { | ||
| function ShowBox() { | ||
|
|
||
| const [text, setText] = useState(""); | ||
|
|
||
| const InputChange = (e) => { | ||
| const inputText = e.target.value; | ||
|
|
||
| setText(inputText); | ||
| }; | ||
|
|
||
| return ( | ||
| <div className="show-box--container"> | ||
| <Input /> | ||
| <Input onChange={InputChange} value={text}/> | ||
| <p className="show-box--text"> | ||
| {/* 여기 안에 Input에서 입력한 값이 나와야 해요. 주석은 지워주세요 */} | ||
| {text ? text : "값을 입력해주세요"} | ||
| </p> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default ShowBox; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: e는 event 약자여서, 이럴땐, value 같은 걸로 변수를 쓰면 좋아요
*NIT: 중요하지는 않지만 더 나은 방법이 있다는 의견을 남기고 싶을 때 사용한다.