Added: Service to create Transfer Order #90
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gurveenbagga
commented
Mar 6, 2025
gurveenbagga
commented
- Added new service create#TransferOrder
- Design - https://github.com/saastechacademy/foundation/pull/124/files
gurveenbagga
requested review from
mridulpathak and
patelanil
and removed request for
mridulpathak
…force-new Running both org.apache.ofbiz.order.order.OrderHeader in transaction=force-new but not required to start new transactions, we can run index order in async mode
patelanil
reviewed
Mar 8, 2025
| --> | ||
|
|
||
| <services xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://moqui.org/xsd/service-definition-3.xsd"> | ||
|
|
There was a problem hiding this comment.
I think we should keep this service simple.
This means,
The key fields should validated before calling this service.
Similarly, If we have externalId, then mapping internal id should be resolved outside of this service.
Such ID resolution should be responsibility of integration module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.