Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci/feat/terragrunt multi module #6738

Open
wants to merge 6 commits into
base: tasking-manager-fastapi
Choose a base branch
from

Conversation

nischalstha9
Copy link
Collaborator

@nischalstha9 nischalstha9 commented Feb 11, 2025

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Related Issue

  • There was no option to run terragrunt workflow to update secrets in AWS Secret Manager.
  • The terragrunt apply stage does not run automatically after plan.
  • There is no review based deployment so anyone is able to deploy infrastructure code.

Describe this PR

This PR adds feature to run terragrunt workflow on different directory with environment based plan and apply stage and GH review based deployment for security purpose.
You can run plan workflow on following modules and after it success, it will auto trigger apply module:

  • purgeable/ecs/
  • non-purgeable/extras/

This PR too adds feature of review based deployment utilizing GitHub Environments. The plan and apply stage are on separate workflow. When the plan workflow (terragrunt plan) completes with review, the apply workflow runs automatically and waits for review to run terragrunt apply.
Closes #6739

@dakotabenjamin
Copy link
Member

Huge number of merge conflicts here that will make it difficult for me to review. Can we also discuss over a call the background of this PR and intentions for merging into the fastapi branch?

@nischalstha9 nischalstha9 force-pushed the ci/feat/terragrunt-multi-module branch from 042a58b to e0c5725 Compare February 14, 2025 05:37
@nischalstha9
Copy link
Collaborator Author

nischalstha9 commented Feb 14, 2025

@dakotabenjamin I have rebased and now there are only changes that need review.
If you are having any kind of confusion or want to discuss this over a call I am happy to attend it. Do invite me at your preferred time.

Copy link
Member

@dakotabenjamin dakotabenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just needs two small changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants